Ensure maxframes setting is respected #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
requested changes
Oct 19, 2021
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Neo4j is free software: you can redistribute it and/or modify |
There was a problem hiding this comment.
Nice to see this moved to an e2e test!
There was a problem hiding this comment.
+1 on loving seeing an e2e test for this! I do wonder though, it seems we're only testing a decrease of the limit, and maybe we should we add an extra test where we increase the limit? wdyt?
There was a problem hiding this comment.
Good idea Jon, I'll add that.
| @@ -193,8 +195,9 @@ function setRecentViewHelper(state: FramesState, recentView: FrameView) { | |||
| } | |||
| } | |||
|
|
|||
| function ensureFrameLimit(state: FramesState) { | |||
| const limit = state.maxFrames || 1 | |||
| /** TODO **/ | |||
| const limit = state.maxFrames || 1 | ||
| /** TODO **/ | ||
| function ensureFrameLimit(state: FramesState, maxFrames: number) { | ||
| const limit = maxFrames || 1 |
There was a problem hiding this comment.
Perhaps we could require maxFrames be larger than 0 here, rather than have a default value? WDYT?
jharris4
reviewed
Oct 19, 2021
| nodePropertiesExpandedByDefault: boolean | ||
| } | ||
|
|
||
| export const initialState: FramesState = { | ||
| allIds: [], | ||
| byId: {}, | ||
| recentView: null, | ||
| maxFrames: 30, |
There was a problem hiding this comment.
Oh nice, at first I was questioning why the default/initial was removed, by now I see it was a duplicate of the default/initial from settings! Really great that you've cleaned this up!
OskarDamkjaer
approved these changes
Oct 19, 2021
jharris4
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.