Support for Neo4j 4.4 SSO, including discovery and refresh tokens #1581
Conversation
OskarDamkjaer
force-pushed
the
connect-discovery
branch
from
4b9c8b9
to
77d1fdc
Compare
| if (SSOProviders) { | ||
| return Rx.Observable.fromPromise( | ||
| (async function() { | ||
| //TODO can throw? |
There was a problem hiding this comment.
yeah, if the handleRefreshingToken throws, we should bail out of the reconnection attempts, and go straight to the connection lost state. TBD is whether we should specifically report this back to the user somehow, possible with custom error text?
| requestedUseDb: action.requestedUseDb, | ||
| host: `${protocol ? `${protocol}//` : ''}${host}`, | ||
| supportsMultiDb: !!action.requestedUseDb, | ||
| encrypted: action.encrypted, |
There was a problem hiding this comment.
I'm a bit fuzzy on while all these discovered properties are needed, and whether they're actually used anywhere, but I guess it's fine for now.
There was a problem hiding this comment.
Yeah this turned into a bit of a rabbit hole trying to understand where they're all used. I'm somewhat certain that the encrypted key is not used here and that the restApi is used for the :http command. But didn't have enough time to dig into it fully
| expect(discoveryData?.urlMissing).toEqual(false) | ||
| }) | ||
|
|
||
| test('finds and priotises sso providers from session storage/connect form when all discovery sources are present, but doesnt merge when hosts differ', async () => { |
There was a problem hiding this comment.
should probably add the new discoveryConnection source to this test?
OskarDamkjaer
force-pushed
the
connect-discovery
branch
2 times, most recently
from
a304c09
to
403e452
Compare
also read/check for it on startup
Also make discovery fetching more aware of auth method values & changes
change discovery connection auth method to sso on provider click misc other sso improvements
OskarDamkjaer
force-pushed
the
connect-discovery
branch
from
4d529d9
to
ee1879d
Compare
OskarDamkjaer
changed the title
No description provided.