Support new alias feature from neo4j 4.4 #1605
Conversation
OskarDamkjaer
force-pushed
the
support_aliases
branch
from
7edc9b3
to
730e1e2
Compare
There was a problem hiding this comment.
Good job!
I have two minor comments in the diff. As we paired together last Thursday, I can understand why you made those changes much quicker.
In addition, it would be great to include unit test and E2E test on this scenario if you've confirmed the UI behaviour with PM?
|
Thanks for the comments, made a few improvements now. Also pushed the last part of the feature, only have testing left to do. I'll re-request your review when ready 🙏 |
OskarDamkjaer
changed the title
| @@ -505,7 +505,6 @@ export const startupConnectEpic = (action$: any, store: any) => { | |||
| ) | |||
|
|
|||
| if ( | |||
| //TODO Considder the SSO implications of this | |||
| !(discovered && discovered.hasForceURL) && // If we have force url, don't try old connection data | |||
There was a problem hiding this comment.
Old comment left in by mistake
| @@ -105,8 +105,6 @@ describe('getAndMergeDiscoveryData', () => { | |||
| expect(discoveryData).toBeTruthy() | |||
| expect(discoveryData?.host).toEqual(boltHost) | |||
|
|
|||
| // expect(discoveryData?.source).toEqual(DISCOVERY_ENDPOINT) | |||
| // Todo test source via logs | |||
There was a problem hiding this comment.
another old comment left in by mistake
| @@ -17,6 +17,7 @@ | |||
| "noFallthroughCasesInSwitch": true, | |||
| "jsx": "react", | |||
| "outDir": "./build", | |||
| "noEmit": true, | |||
There was a problem hiding this comment.
Set tsc to not emit any javascript when it runs, since we don't use tsc for compiling but we get weird errors when running the tests if we have accidentally have generated some js code
OskarDamkjaer
changed the title
|
As soon as it's released! |
|
Merging as soon as the tests come back green |
Adds support for the 4.4 concept of aliases.
To create an alias run
create alias myAlias for database neo4j.You should not be able to run
:use myAliasand see your aliases when running:dbs. The "real" name should still be displaced in editor.Preview @http://support_aliases.surge.sh