Show hint about :auto on CALL {...} IN TRANSACTIONS #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
changed the title
OskarDamkjaer
force-pushed
the
update_warning
branch
from
892530a
to
285ff2a
Compare
OskarDamkjaer
force-pushed
the
update_warning
branch
from
54a038b
to
c59333c
Compare
nglgzz
reviewed
Jan 27, 2022
|
|
||
| it('adding :auto enables running periodic commit', () => { | ||
| cy.executeCommand(':auto USING PERIODIC COMMIT RETURN "Laverre";') | ||
| cy.getFrames().contains('ERROR') |
There was a problem hiding this comment.
Could you add a comment explaining why we're looking for an error here?
There was a problem hiding this comment.
sure, it definitely looks a bit odd
OskarDamkjaer
force-pushed
the
update_warning
branch
from
96e6d22
to
e7e5cfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a few regex checks on error messages to see if the error was caused by a missing
:autoprefix, if so we add a hint to the error message.This PR adds a check for if the error is the new
CALL IN {} TRANSACTIONSwhich needs :auto and updates the check forPERIODIC COMMIT(that has the new error message"A query with 'PERIODIC COMMIT' can only be executed in an implicit transaction but tried to execute in an explicit transaction.").I also add a few tests to verify the behaviour, updated the
:help autoto use the new syntax and added a helper method to cypress for faster tests.URL for testing: update_warning.surge.sh
Do note that a 4.4 db is needed.