Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting :params on multiple lines #1651

Merged
merged 3 commits into from Jan 25, 2022
Merged

Enable setting :params on multiple lines #1651

merged 3 commits into from Jan 25, 2022

Conversation

eijawerner
Copy link
Contributor

@eijawerner eijawerner commented Jan 24, 2022 •
edited

Now it is possible to use :params command with multiple lines Screenshot 2022-01-24 at 15 05 34

OskarDamkjaer
OskarDamkjaer approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you found such a clean fix! 🙏

OskarDamkjaer
OskarDamkjaer approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get a few more tests and typescript fixes along for the ride!

@eijawerner eijawerner merged commit e63ee65 into neo4j:master Jan 25, 2022
@eijawerner eijawerner deleted the fix-set-params-multiline branch January 25, 2022 14:17
@OskarDamkjaer OskarDamkjaer changed the title Fixed so possible to set params using multiline Enable setting :params on multiple lines Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarDamkjaer OskarDamkjaer OskarDamkjaer approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eijawerner @OskarDamkjaer