Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom to fit button #1657

Merged
merged 1 commit into from Feb 1, 2022
Merged

Add zoom to fit button #1657

merged 1 commit into from Feb 1, 2022

Conversation

eijawerner
Copy link
Contributor

@eijawerner eijawerner commented Jan 31, 2022

  • Now possible to zoom to fit the whole graph
    • Avoid zooming in more than max limit for really small graphs, currently no limit for zooming out when pressing the zoom to fit button.
  • Also added new icons for zoom in/out and fixed styling according to latest designs.
  • Changed old icon buttons to have the same background states as in the new designs, however doesn't change the color yet, since the old icons are smaller and thinner it makes them more difficult to read. Remove the legacy color when all new icons are in place.
    (- NOT included: to be done in later PR, get the icons and color from design library when that is released)

New:
Screenshot 2022-01-31 at 14 42 24
Old:
Screenshot 2022-01-31 at 14 42 05

@OskarDamkjaer
Copy link
Contributor

Is it possible to centre the graph taking the panel width into account? If it's expanded it looks a bit nicer having it be centred of the available space.
https://user-images.githubusercontent.com/10564538/151823616-43c5eff6-447e-4a3d-83d5-a30058cf42fd.mp4

@eijawerner
Copy link
Contributor Author

Is it possible to centre the graph taking the panel width into account? If it's expanded it looks a bit nicer having it be centred of the available space. https://user-images.githubusercontent.com/10564538/151823616-43c5eff6-447e-4a3d-83d5-a30058cf42fd.mp4

I agree that it would be nice, however I'd like to keep the scope down of this PR and this is current behavior in Bloom as well, so I keep it as it is for now.

Also added new icons for zoom in/out and fixed styling according to latest designs.

Changed old icon buttons to have the same background states as in the new designs, however doesn't change the color yet, since the old icons are smaller and thinner it makes them more difficult to read. Remove the legacy color when all new icons are in place.
@eijawerner eijawerner merged commit 4f17afc into neo4j:master Feb 1, 2022
@eijawerner eijawerner deleted the zoom-to-fit branch February 1, 2022 11:05
@OskarDamkjaer OskarDamkjaer changed the title Added button for zooming to fit to available space for graph and updated styles for zoom Add zoom to fit button Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants