Zoom mod key info message #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eijawerner
commented
Feb 3, 2022
•
eijawerner
commented
eijawerner
force-pushed
the
zoom-mod-key-info-message
branch
from
77c37b4
to
de79cfb
Compare
eijawerner
force-pushed
the
zoom-mod-key-info-message
branch
3 times, most recently
from
19f5963
to
f2596e1
Compare
eijawerner
force-pushed
the
zoom-mod-key-info-message
branch
from
f2596e1
to
62be716
Compare
src/browser/modules/D3Visualization/components/WheelZoomInfoOverlay.tsx
Outdated
Show resolved
Hide resolved
src/browser/modules/D3Visualization/components/WheelZoomInfoOverlay.tsx
Outdated
Show resolved
Hide resolved
eijawerner
force-pushed
the
zoom-mod-key-info-message
branch
from
62be716
to
6d9863c
Compare
OskarDamkjaer
approved these changes
Feb 8, 2022
|
Nice! Let's merge on green! |
Also renamed Settings component to UserSettings since it is not as tightly linked to Settings in redux as you might expect from the name. Added setting to regret clicking do not display again on wheel zoom info message.
since causing problems with circular dependencies in test, but also it makes sense to put in a util file instead.
eijawerner
force-pushed
the
zoom-mod-key-info-message
branch
from
6d9863c
to
066389c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.