Handle null values in graph viz #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nglgzz
reviewed
Feb 15, 2022
| @@ -25,7 +25,9 @@ import { optionalToString } from 'services/utils' | |||
|
|
|||
| const mapProperties = (_: any) => Object.assign({}, ...stringifyValues(_)) | |||
| const stringifyValues = (obj: any) => | |||
| Object.keys(obj).map(k => ({ [k]: optionalToString(obj[k]) })) | |||
| Object.keys(obj).map(k => ({ | |||
| [k]: obj[k] === null ? 'null' : optionalToString(obj[k]) | |||
There was a problem hiding this comment.
Might want to get rid of the optionalToString function as it's used only here. Not necessary though
nglgzz
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stringify all node property values except
null, which causes crashes later on. This PR makes we handle null, and that the correct type hint show up as well. Preview at http://handle_null_properties.surge.sh, easiest way to trigger the crash is runcall apoc.create.vNode(['stuff'], {id:5, blah:null})and hover the created node.Here's a screen shot of how it looks now: