Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote guides - resovle config ’*’ to default whitelist #860

Merged
merged 2 commits into from Nov 5, 2018

Conversation

oskarhane
Copy link
Member

With the browser.remote_content_hostname_whitelist config set to *, neo4j browser now tries to resolve guides on the default hosts (guides.neo4j.com, localhost) so they more easily can be played.

Example: :play reco now looks for a guide on (in that order)

https://guides.neo4j.com/reco
http://guides.neo4j.com/reco
https://localhost/reco
http://localhost/reco

The behavior for configurations of browser.remote_content_hostname_whitelist set to anything else should be unchanged.

Before

oskarhane-mbpt 2018-11-01 at 11 46 25

After

oskarhane-mbpt 2018-11-01 at 11 46 45

@oskarhane oskarhane force-pushed the play-from-guides branch 5 times, most recently from c69e86d to b654691 Compare November 1, 2018 13:15
@oskarhane oskarhane force-pushed the play-from-guides branch 3 times, most recently from e233b67 to 918a9c3 Compare November 4, 2018 20:58
@oskarhane oskarhane merged commit ecb84ce into neo4j:master Nov 5, 2018
@oskarhane oskarhane deleted the play-from-guides branch November 5, 2018 07:53
myzero1 pushed a commit to myzero1/neo4j-browser that referenced this pull request May 17, 2019
Remote guides - resovle config ’*’ to default whitelist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant