Idle timer on each pooled connection to record the idle time elapsed #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elapsed. By default the connection pool will not timeout any connection inside the pool. As long as the connection is still "open", then the connection is reused. While a user could enable idle timeout on connections by setting `ConnectionIdleTimeout` to be a non-negative number. Then when reusing connections from the pool, connections that have been idle for longer than the configured time will be closed directly. Notes: * The timer is implemented using `Stopwatch`, the time elapsed is loosely precise. * The connection will not immediately be closed when idle timeout reached, instead it will be closed in the same thread that get it out of the pool.
|
@cskardon I am trying to start solving #145 by making smaller changes. So this PR added a simple timer on each connection and let the pool close the connections that has been idle for too long in the caller thread. It would be great if we do not need to introduce another thread to close connections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the connection pool will not timeout any connection inside the pool. As long as the connection is still "open", then the connection is reused.
While a user could enable idle timeout on connections by setting
ConnectionIdleTimeoutto be a non-negative number.Then when reusing connections from the pool, connections that have been idle for longer than the configured time will be closed directly.
Notes:
Stopwatch, the time elapsed is loosely precise.