Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing context support in uri #168

Merged
merged 5 commits into from
Apr 21, 2017
Merged

Conversation

zhenlineo
Copy link
Contributor

@zhenlineo zhenlineo commented Apr 12, 2017

Made driver aware getRoutingTable in 3.2+ server
Made driver parse routing context from uri

@zhenlineo zhenlineo force-pushed the 1.3-routing-context branch 2 times, most recently from ef212fb to cbb42c0 Compare April 13, 2017 13:57
Copy link
Contributor

@lutovich lutovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhenlineo looks good, one comment about additional tests.

{
public class NetworkExtensionsTests
{
public class ParseRoutingContextMethod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also include tests without port, without routing params and for uri like this bolt://localhost/? because it is also a valid one.

@zhenlineo zhenlineo force-pushed the 1.3-routing-context branch 4 times, most recently from 0ae6d93 to af6d417 Compare April 21, 2017 12:02
@zhenlineo zhenlineo merged commit 85b40e4 into neo4j:1.3 Apr 21, 2017
@zhenlineo zhenlineo deleted the 1.3-routing-context branch April 21, 2017 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants