Refactoring to prepare for async methods #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nager to simplify the logic in LoadBalancer.
lutovich
approved these changes
Jul 13, 2017
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. |
There was a problem hiding this comment.
Is this licence header needed?
| } | ||
| } | ||
|
|
||
| public class TryAcquireConnectionMethod |
There was a problem hiding this comment.
This class is probably not needed
| } | ||
| } | ||
| } | ||
| var name = mode == AccessMode.Read ? "read" : "wrtie"; |
There was a problem hiding this comment.
Maybe mode.ToString().ToLower()? Just to avoid manual string conversion
ali-ince
approved these changes
Jul 13, 2017
| @@ -32,22 +32,23 @@ internal class RoundRobinRoutingTable : IRoutingTable | |||
| private readonly Stopwatch _stopwatch; | |||
| private readonly long _expireAfterSeconds; | |||
|
|
|||
| public RoundRobinRoutingTable(Stopwatch stopwatch, long expireAfterSeconds = 0) | |||
| public RoundRobinRoutingTable(IEnumerable<Uri> routers, long expireAfterSeconds = 0) | |||
There was a problem hiding this comment.
This constructor may call the other one using Enumerable.Empty() for readers and writers parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to pull RoutingTable and Rediscovery in to RoutingTableManager to simplify the logic in LoadBalancer.