Decouple routing logic from address set #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a separate load balancing strategy abstraction responsible for address selection.
Commit changes `TryAcquire` with out parameter to simple `Acquire` that either returns a connection or null.
ali-ince
approved these changes
Jul 18, 2017
| value = _items[_index++]; | ||
| } | ||
| return true; | ||
| _items = new List<T>(); |
There was a problem hiding this comment.
Should we also make this assignment a critical section?
There was a problem hiding this comment.
Yes, good point. It is fine for #Clear() to assign because it is an atomic action, but it is not fine for it to not coordinate with other modification methods like #Add() or #Remove().
| /// Not thread safe | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| string ToString(); |
There was a problem hiding this comment.
There's no need for a ToString() declaration as it is part of Object class that can be overrided.
Re-assignment of the internal list needs to be done while holding a lock so that it is coordinated and isolated from other modifications like `#Add()` or `#Remove()`.
|
@ali-ince comments should now be addresses. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.