Fix for Keys availability upon Session.RunAsync and Transaction.RunAsync #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
suggested changes
Sep 15, 2017
| @@ -222,6 +223,10 @@ public override Task<IStatementResultCursor> RunAsync(Statement statement) | |||
| _connection.Server); | |||
| _connection.Run(statement.Text, statement.Parameters, resultBuilder); | |||
| await _connection.SendAsync().ConfigureAwait(false); | |||
|
|
|||
| // Wait for SUCCESS/FAILURE message from the server | |||
| await _connection.ReceiveOneAsync().ConfigureAwait(false); | |||
There was a problem hiding this comment.
I thought for transaction run, if we did not provide bookmark, at line 225 we would have queued messages:
Run Begin
Pull_All
Run transaction XX
Pull_All
Then if we send and just wait for the first reply, then we only got reply for Run Begin?
I am now wondering why tests would pass...
There was a problem hiding this comment.
I tested locally, the receiveOneAsync will only wait for Success for the firstRun Begin message. While as we batching messages and handle them together if them fit in buffer, when Success for Run Begin returns, the others messages also arrived and processed in time.
…t Keys are populated when requested)
zhenlineo
approved these changes
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.