Ensure stream position to be reset before returning task #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling
ReadNextMessagesAsync
calls, we record message stream buffer position and reset it to that recorded value just after actual read messages operation completes. However, the returned task fromReadNextMessagesAsync
call does not include the task continuation that resets the position - and returns the original task. This may sometimes cause the message reading operation resume from an incorrect buffer position which causes an unexpected byte sequence and halts withProtocolException
.This PR fixes the issue by returning the expeccted position resetting task continuation as the result from
ReadNextMessagesAsync
method.