Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simpler config based SSL certificate management #585

Merged
merged 28 commits into from
Mar 4, 2022
Merged

Add simpler config based SSL certificate management #585

merged 28 commits into from
Mar 4, 2022

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented Feb 8, 2022 •
edited
Loading

ConfigBuilder allows for a simpler configuration of SSL using WithCertificateTrustRule

AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some much needed tidying up on the TrustManager surface was a nice extra

@thelonelyvulpes thelonelyvulpes merged commit fcd0495 into 5.0 Mar 4, 2022
@thelonelyvulpes thelonelyvulpes deleted the feature/security-config branch March 4, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thelonelyvulpes @AndyHeap-NeoTech