New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce GetServerInfoAsync to IDriver, unify behaviour of VerifyConnectivityAsync #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thelonelyvulpes
commented
Apr 8, 2022
•
edited
edited
- Update VerifyConnectivityAsync on driver to be inline with other drivers.
- Introduce GetServerInfoAsync to driver, which provides connection validation with server details.
- Implement Testkit flags for aforementioned functions
thelonelyvulpes
force-pushed
the
feature/verify-connectivity
branch
from
April 14, 2022 14:39
ba104e7
to
340138b
Compare
AndyHeap-NeoTech
approved these changes
Apr 25, 2022
thelonelyvulpes
force-pushed
the
feature/verify-connectivity
branch
6 times, most recently
from
May 5, 2022 10:00
0bf8add
to
c561fa3
Compare
thelonelyvulpes
force-pushed
the
feature/verify-connectivity
branch
from
May 5, 2022 10:17
c561fa3
to
a9e2e37
Compare
thelonelyvulpes
commented
May 5, 2022
thelonelyvulpes
commented
May 5, 2022
AndyHeap-NeoTech
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.