Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retriable exceptions #613

Merged
merged 6 commits into from May 13, 2022
Merged

Retriable exceptions #613

merged 6 commits into from May 13, 2022

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented May 11, 2022 •
edited

  • Neo4jExceptions return bool if can be retried using CanBeRetried Property.
  • Compatability mapping for 4.4 servers and 5.0 driver for codes:
    • Neo.TransientError.Transaction.Terminated
    • Neo.TransientError.Transaction.LockClientStopped
  • Rename exception extensions method from .IsRetriableError to .CanBeRetried.

@thelonelyvulpes thelonelyvulpes marked this pull request as ready for review May 11, 2022 11:13
@thelonelyvulpes thelonelyvulpes force-pushed the feature/5.0-retriable-exceptions branch from af2bc66 to fe764a8 Compare May 11, 2022 11:15
AndyHeap-NeoTech
AndyHeap-NeoTech reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question on the naming of the V1 serializer. The rest of it looks like a good implementation.

Neo4j.Driver/Neo4j.Driver/Internal/IO/MessageSerializers/FailureMessageV1Serializer.cs Outdated Show resolved Hide resolved
@thelonelyvulpes thelonelyvulpes merged commit c8491f5 into 5.0 May 13, 2022
@thelonelyvulpes thelonelyvulpes deleted the feature/5.0-retriable-exceptions branch May 13, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thelonelyvulpes @AndyHeap-NeoTech