Reactive & Simple Transaction lifetimes. #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyHeap-NeoTech
approved these changes
Sep 8, 2022
| @@ -122,6 +122,26 @@ public IObservable<T> WriteTransaction<T>(Func<IRxTransaction, IObservable<T>> w | |||
| return RunTransaction(AccessMode.Write, work, action); | |||
| } | |||
|
|
|||
| public IObservable<T> ExecuteRead<T>(Func<IRxRunnable, IObservable<T>> work) | |||
| { | |||
| return ReadTransaction(work, null); | |||
There was a problem hiding this comment.
Just wondering if leaving the internal method name(s) ReadTransaction and WriteTransaction as is makes sense, or does it introduces confusion with the deprecated methods?
There was a problem hiding this comment.
fair comment, I will avoid using the deprecated methods in the new methods.
thelonelyvulpes
deleted the
fix/deprecate-rx-simple-read-write-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Rx and Simple driver Tx lifetime changes.