Re auth #689
Merged
Re auth #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardIrons-neo4j
force-pushed
the
re_auth
branch
from
a7e3976
to
791c227
Compare
Neo4j.Driver/Neo4j.Driver/Internal/Connector/PooledConnection.cs
Outdated
Show resolved
Hide resolved
Neo4j.Driver/Neo4j.Driver/Internal/Connector/SocketConnection.cs
Outdated
Show resolved
Hide resolved
Neo4j.Driver/Neo4j.Driver/Internal/Services/DateTimeProvider.cs
Outdated
Show resolved
Hide resolved
Reauth handling for routing, and 5.0 protocol.
thelonelyvulpes
requested changes
May 24, 2023
|
|
||
| namespace Neo4j.Driver.Auth; | ||
|
|
||
| public record AuthTokenAndExpiration |
There was a problem hiding this comment.
class doesn't have documentation
Neo4j.Driver/Neo4j.Driver.Tests/Internal/Protocol/BoltProtocolV3Tests.cs
Show resolved
Hide resolved
| Assembly | ||
| .GetExecutingAssembly() | ||
| .DefinedTypes | ||
| .Where(t => t.IsAssignableTo(typeof(IProtocolObject)))); |
There was a problem hiding this comment.
While this is nicer one issue it leads to is all the classes being highlighted as unused, we could disable that check on all of them though
…ns for uninitialized connections
…andlers. fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Authentication (preview)
Introduces updated authentication APIs which cover several features.
AuthTokenManagers (5.9 API Docs)
AuthTokenManagers allows the creation of a new IAuthTokenManager instance which can be then be used when instantiating a driver instance preview interface.
Session Tokens (5.9 API Docs)
Sessions can now be configured with an auth token.
Session tokens require server version 5.6+ this can be checked for with
IDriver.SupportsSessionAuthAsync5.9 API DocsPreview status & Feedback wanted
Introduced in preview status so APIs could see change.
Any feedback is welcome: Discussion.