Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications config #691

Merged
merged 30 commits into from Mar 30, 2023
Merged

Notifications config #691

merged 30 commits into from Mar 30, 2023

Conversation

thelonelyvulpes
Copy link
Contributor

No description provided.

@thelonelyvulpes thelonelyvulpes changed the title [WIP]Notifications config take two Notifications config Mar 16, 2023
AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The classic driver feature that requires something to be passed down through x number of layers :)

Just a couple of comments on minor style things where it is slightly inconsistent within a class.

Neo4j.Driver/Neo4j.Driver/Config.cs Show resolved Hide resolved
Neo4j.Driver/Neo4j.Driver/Internal/AsyncSession.cs Outdated Show resolved Hide resolved
Neo4j.Driver/Neo4j.Driver/Internal/Connector/IConnection.cs Outdated Show resolved Hide resolved
Neo4j.Driver/Neo4j.Driver/Internal/MessageHandling/Metadata/NotificationsCollector.cs Outdated Show resolved Hide resolved
Neo4j.Driver/Neo4j.Driver/Internal/Protocol/BoltProtocolMessageFactory.cs Outdated Show resolved Hide resolved
@RichardIrons-neo4j
Copy link
Contributor

Just a small thing about magic strings. All looks good.

@thelonelyvulpes thelonelyvulpes merged commit df22aeb into neo4j:5.0 Mar 30, 2023
@thelonelyvulpes thelonelyvulpes deleted the feature/notifications-take-two branch March 30, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardIrons-neo4j RichardIrons-neo4j RichardIrons-neo4j left review comments

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thelonelyvulpes @RichardIrons-neo4j @AndyHeap-NeoTech