New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction error handling #737

Merged

thelonelyvulpes merged 15 commits into neo4j:5.0 from thelonelyvulpes:transaction-error-handling

Oct 18, 2023

Contributor

thelonelyvulpes commented Oct 10, 2023 •

edited

This change introduces a mechanism to remove undefined behaviors when the user code catches and ignores an exception and attempts to use a terminated transaction further.

When a result is a constituent of the transaction, and that transaction is terminated, all results are invalidated.

thelonelyvulpes added 3 commits

October 10, 2023 11:31


          add basic infra to support transactions errors being visible to all c…

101c4cd

…ursors.


          Testkit passing

efc4bbd


          fix unit tests

57e847c

Contributor Author

thelonelyvulpes commented Oct 10, 2023 •

edited

Requires neo4j-drivers/testkit#601 & neo4j-drivers/testkit#603

thelonelyvulpes added 2 commits

October 11, 2023 09:35


          Replace the pipeline errors being thrown

5544e48


          Add result builder and cursor test to verify transaction terminated.

a8fe708

thelonelyvulpes marked this pull request as ready for review

October 11, 2023 13:56


          Remove region

9ed6ae0

thelonelyvulpes requested review from RichardIrons-neo4j and AndyHeap-NeoTech

October 11, 2023 13:59

thelonelyvulpes commented

View reviewed changes

Neo4j.Driver/Neo4j.Driver/Internal/AsyncTransaction.cs Outdated Show resolved Hide resolved

thelonelyvulpes commented

View reviewed changes

Neo4j.Driver/Neo4j.Driver/Internal/Result/ConsumableResultCursor.cs Outdated Show resolved Hide resolved

thelonelyvulpes commented

View reviewed changes

Neo4j.Driver/Neo4j.Driver/Internal/Protocol/Utility/FakeTransaction.cs Outdated Show resolved Hide resolved

thelonelyvulpes commented

View reviewed changes

Neo4j.Driver/Neo4j.Driver/Internal/Protocol/IBoltProtocol.cs Show resolved Hide resolved

thelonelyvulpes commented

View reviewed changes

Neo4j.Driver/Neo4j.Driver/Internal/Protocol/BoltProtocolV3.cs Show resolved Hide resolved

thelonelyvulpes added 7 commits

October 11, 2023 15:45


          formatting

6eb5826


          Merge branch '5.0' into transaction-error-handling

0b0fef7


          refactor solution due to incompatibility with other tests

1c25d02


          Remove unneeded changes to IResultCursor

05fa62d


          Delegate IsRetriable to inner exception

a0de142


          move some throws and fix a test

8bb7afb


          Fix unit tests for handling failed.

74f4ae2

robsdedude mentioned this pull request

Add new notification categories SECURITY and TOPOLOGY neo4j-drivers/testkit#600

Merged

RichardIrons-neo4j reviewed

View reviewed changes

Neo4j.Driver/Neo4j.Driver.Tests/Internal/Protocol/BoltProtocolTests.cs Outdated Show resolved Hide resolved

Neo4j.Driver/Neo4j.Driver/Internal/Protocol/Utility/FakeTransaction.cs Outdated Show resolved Hide resolved

thelonelyvulpes and others added 2 commits

October 17, 2023 21:53


          Update Neo4j.Driver/Neo4j.Driver.Tests/Internal/Protocol/BoltProtocol…

ef0f861

…Tests.cs

Co-authored-by: Richard Irons <115992270+RichardIrons-neo4j@users.noreply.github.com>


          Rename fake transaction to NullTransaction

thelonelyvulpes requested a review from RichardIrons-neo4j

October 18, 2023 07:13

RichardIrons-neo4j approved these changes

View reviewed changes

thelonelyvulpes merged commit 3f560cf into neo4j:5.0

5 checks passed

thelonelyvulpes deleted the transaction-error-handling branch

October 18, 2023 08:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment