Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect default memory pool for bolt #758

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Protect default memory pool for bolt #758

merged 4 commits into from
Dec 14, 2023

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented Dec 13, 2023 •
edited
Loading

This change introduces and defaults the pool used for bolt to a hermetic pool, and removes the ability to disable new pipeline reader

  • The best pool to use is the shared pool as it means any buffers allocated are shared to the application, but this exposes users to a level of risk, while we should suggest users use the shared pool, the default should remain isolated.

RichardIrons-neo4j
RichardIrons-neo4j approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@RichardIrons-neo4j RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Makes sense to use a separate memory pool as the default.

@thelonelyvulpes thelonelyvulpes merged commit acb8ff6 into neo4j:5.0 Dec 14, 2023
5 checks passed
@thelonelyvulpes thelonelyvulpes deleted the switch-default-pool branch December 14, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

@RichardIrons-neo4j RichardIrons-neo4j RichardIrons-neo4j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thelonelyvulpes @AndyHeap-NeoTech @RichardIrons-neo4j