Invariant capable records #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neo4j.Driver/Neo4j.Driver/Internal/Result/ResultCursorBuilder.cs
Outdated
Show resolved
Hide resolved
thelonelyvulpes
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Record type so that it does not contain a dictionary on every instance, instead only containing the array of values, and references to two dictionaries shared across the whole cursor: one just a straight Dictionary<string, object>, and the other of the same type but using an InvariantCultureCaseInsensitive string comparer, so that values can be looked up using a case insensitive key, used in the object mapping.
Added Get and TryGet methods to IRecord and IEntity, and added xxxCaseInsensitive versions of those methods to IRecord.
More tests added, tests modified to create records through
TestRecord.Create.