Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Api Telemetry #1487

Merged
merged 20 commits into from
Oct 4, 2023
Merged

Introduce Api Telemetry #1487

merged 20 commits into from
Oct 4, 2023

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Sep 26, 2023

Neo4j would like to be able to track more information about driver apis usage, so that smarter decisions can be made on improving drivers and their stack.

The collection of metrics must be respectful of users. Thus, the collected metrics are:

  1. impossible to be tied back the customer or user
  2. transparent to the users that inspect
  3. restrained to required metrics

The metric collection is disabled by default in Neo4j. It can be enabled in the server by setting server.bolt.telemetry.enabled to true.

However, the metric collection is enabled by default in the drivers. It can be disabled in the driver by configuring the driver with telemetryDisabled to true. Default: false.

Metrics are only collected when enabled both in server and driver instances.

@bigmontz bigmontz marked this pull request as ready for review September 28, 2023 14:59
@injectives injectives merged commit 92e7341 into neo4j:5.0 Oct 4, 2023
16 of 20 checks passed
injectives added a commit that referenced this pull request Oct 4, 2023
Copy link
Contributor

@injectives injectives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testkit failed because of flaky tests unrelated to this.

@bigmontz bigmontz deleted the 5.x-telemetry branch October 5, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants