Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GQL-status objects #1555

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Add support for GQL-status objects #1555

merged 6 commits into from
Jun 20, 2024

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Jun 1, 2024 •
edited
Loading

This update adds support for GQL-status objects defined in the GQL standard.

@injectives injectives marked this pull request as draft June 1, 2024 12:28
@injectives injectives force-pushed the feature/gql branch 5 times, most recently from 5498dd5 to 3137198 Compare June 1, 2024 14:39
@injectives injectives changed the title Add support for GQL Status Object Add support for GQL-status objects Jun 11, 2024
@injectives injectives force-pushed the feature/gql branch 17 times, most recently from b336322 to 667231b Compare June 12, 2024 15:41
@injectives injectives marked this pull request as ready for review June 12, 2024 15:41
@injectives
Add support for GQL-status objects
3af41d6 
This update adds support for GQL-status objects defined in the GQL standard.
@injectives injectives requested a review from bigmontz June 13, 2024 10:56
bigmontz
bigmontz requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not deprecate the current apis yet and the new apis should be released as preview.

driver/src/main/java/org/neo4j/driver/Config.java Show resolved Hide resolved
driver/src/main/java/org/neo4j/driver/Config.java Outdated Show resolved Hide resolved
driver/src/main/java/org/neo4j/driver/internal/summary/InternalNotification.java Show resolved Hide resolved
driver/src/test/java/org/neo4j/driver/internal/util/MetadataExtractorTest.java Show resolved Hide resolved
driver/src/main/java/org/neo4j/driver/summary/GqlStatusObject.java Show resolved Hide resolved
@injectives injectives requested a review from bigmontz June 13, 2024 13:36
@injectives injectives requested a review from bigmontz June 13, 2024 14:01
bigmontz
bigmontz approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔔

meistermeier
meistermeier reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@meistermeier meistermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely ignored the bits around the communication layer because I have not much knowledge here.
Some remarks on dependencies and inheritance.

driver/src/main/java/org/neo4j/driver/summary/Notification.java Show resolved Hide resolved
driver/src/main/java/org/neo4j/driver/NotificationCategory.java Show resolved Hide resolved
driver/src/main/java/org/neo4j/driver/Config.java Show resolved Hide resolved
@injectives injectives merged commit e5d1bfe into neo4j:5.0 Jun 20, 2024
20 checks passed
@injectives injectives deleted the feature/gql branch June 20, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meistermeier meistermeier meistermeier left review comments

@bigmontz bigmontz bigmontz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@injectives @meistermeier @bigmontz