Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to driver #244

Merged
merged 4 commits into from
Oct 7, 2016
Merged

Fixes to driver #244

merged 4 commits into from
Oct 7, 2016

Commits on Oct 6, 2016

  1. Do not fail i ACK_FAIL is responded with IGNORE

    @pontusmelke
    pontusmelke committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    d17b10a View commit details
    Browse the repository at this point in the history

  2. Don't add the same connection multiple times 

    The same connections was being added to the queue if close was called more
than once. Eventually the queue will be full and we close the connection, but
since the queue now contains multiple identical copies we will also close these.
    @pontusmelke
    pontusmelke committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    cdc79ca View commit details
    Browse the repository at this point in the history

  3. Switch to ConnectionFailureException

    @pontusmelke
    pontusmelke committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    5540e80 View commit details
    Browse the repository at this point in the history

  4. Make sure connection is only called once. 

    Instead of guarding in `PooledConnection` as well as in `NetworkSession` we
make sure we only close connection once in `RoutingDriver`
    @pontusmelke
    pontusmelke committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    3004db0 View commit details
    Browse the repository at this point in the history