Mapping Exception for entities with same Simple ClassName but different Labels

[viggys]

I have two entity classes with same SimpleName but in different packages and with different NodeEntity Labels. All the repository methods seem to work fine with both the classes, except for any repository method using @ Query annotation.

Facing OGM MappingException: More than one class has simple name.
This is happening as the class SimpleName is being used (in below code) to find the ClassInfo from session metadata, where actually the ClassInfo is mapped using either the NodeEntity Label or the Class FQN.

org.neo4j.ogm.session.delegates.ExecuteQueriesDelegate.lambda$executeAndMap$1(ExecuteQueriesDelegate.java:119)
session.metaData().classInfo(type.getSimpleName())

Expected Behavior

To find the mapping ClassInfo, execute and return the Query result.

Current Behavior

Facing below OGM Exception,
org.neo4j.ogm.exception.core.MappingException: More than one class has simple name

Possible Solution

Using Class FullQualifiedName instead of SimpleName ExecuteQueriesDelegate.executeAndMap to find the ClassInfo seems to work. Expecting suggestions on the fix.

Steps to Reproduce (for bugs)

1. Create two POJOs with same Name, but in different packages with different NodeEntity labels
2. Create a repository method using native @ Query

Context

The goal is to use multiple node entity classes with same name but in different packages and work with the spring data repositories.

Your Environment

• OGM Version used: 3.1.5
• Java Version used: 1.8
• Neo4J Version used: 3.5.0

[meistermeier]

Related to #552 / #712

[meistermeier]

Thanks for reporting this. You are totally right with your finding and that this should not happen. A fix is on its way.

[viggys]

Cool. Thank you @meistermeier for your immediate fix. This should solve the issue.

[michael-simons]

Thanks, @viggys for your report :) we will close the ticket as soon as the fix is on the relevant branches.