Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for GH-952 now useless #957

Closed
nioertel opened this issue Aug 26, 2023 · 2 comments
Closed

Unit test for GH-952 now useless #957

nioertel opened this issue Aug 26, 2023 · 2 comments
Assignees

Comments

@nioertel
Copy link
Contributor

The test I introduced for #952 only works with reliable native ids. The reason is that it verifies correct behavior for the case when nodes and relationships in the query result have the same native ids.
Commit f59fadd (@meistermeier) changed the test so that it's now meaningless.

Either the test should be reverted to its original state (being well aware that it needs to be executed within a clean JVM, which is achieved via the Maven configuration that was introduced with the change).
Or another test strategy is needed that can achieve the required test setup from any previous state.

Niels

@meistermeier meistermeier self-assigned this Aug 28, 2023
@meistermeier
Copy link
Collaborator

Sorry. This was not intended. Will have a look.

@meistermeier
Copy link
Collaborator

Reverted the test. Sorry again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants