Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store visited NodeBuilder along with horizon #433

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Store visited NodeBuilder along with horizon #433

merged 3 commits into from
Nov 15, 2017

Conversation

frant-hartm
Copy link
Contributor

When a node is reached at horizon 0 it is marked as visited.
After reaching the node again, with horizon >0 its relationships
should be visited.

This commit stores the horizon in CypherContext and uses it to evaluate
if the traversal should continue.

Related Issue

Fixes #407

Motivation and Context

How Has This Been Tested?

unit tests included

Types of changes

  • [/] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [/] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [/] I have added tests to cover my changes.
  • [/] All new and existing tests passed.

When a node is reached at horizon 0 it is marked as visited.
After reaching the node again, with horizon >0 its relationships
should be visited.

This commit stores the horizon in CypherContext and uses it to evaluate
if the traversal should continue.

Fixes #407.
Copy link
Member

@nmervaillie nmervaillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node references are visited on unpredictable order leading to unsaved changes.
2 participants