New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-787 - Use converter for id based loading. #788

Merged

meistermeier merged 1 commit into master from issue/GH-787

Apr 20, 2020

Collaborator

meistermeier commented Apr 9, 2020

Call the AttributeConverter when querying for types with custom ids.

Because there cannot be one central place to call the conversion upfront, we need to do it for load and loadAll separately.

Closes GH-787


          GH-787 - Use converter for id based loading.

c62d586

meistermeier requested a review from michael-simons

April 9, 2020 08:56

michael-simons approved these changes

View reviewed changes

Collaborator

michael-simons left a comment

Regarding the inline comment, I cannot resist. I am kinda sorry:

meistermeier merged commit 15af68d into master

michael-simons deleted the issue/GH-787 branch

May 6, 2020 10:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment