Fix reading of Neo4j literal byte[] arrays. #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We optimized the previous `convertToIterable` (now `iterableOf` in `CollectionUtils` to actually return an iterable. In the case of byte arrays, the `EntityAccessManager` casts that `Iterable` into a collection to coerce it with existing values. That lead to the `ClassCastException` mentioned in #791. The issue needs several fixes: - `EntityAccessManager` must only work on `Iterables` - The `CollectionUtils` must treat an array of primitive types separatly. It cannot be just casted into an `Object[]` array. This change also introduces two NoOp-Converter (`NoOpByteArrayConverter` and `NoOpWrappedByteArrayConverter`) that allow users to circumenvent the conversion to Base64 arrays. We can read Base64 encoded into byte[] arrays from HTTP, but not write byte[] arrays over HTTP as the HTTP endpoint doesn’t support byte[] as parameter. This closes #791.
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
=========================================
Coverage 80.32% 80.33%
- Complexity 3016 3031 +15
=========================================
Files 275 277 +2
Lines 9218 9248 +30
Branches 1377 1380 +3
=========================================
+ Hits 7404 7429 +25
Misses 1310 1310
- Partials 504 509 +5
Continue to review full report at Codecov.
|
michael-simons
added a commit
that referenced
this pull request
May 6, 2020
We optimized the previous `convertToIterable` (now `iterableOf` in `CollectionUtils` to actually return an iterable. In the case of byte arrays, the `EntityAccessManager` casts that `Iterable` into a collection to coerce it with existing values. That lead to the `ClassCastException` mentioned in #791. The issue needs several fixes: - `EntityAccessManager` must only work on `Iterables` - The `CollectionUtils` must treat an array of primitive types separately. It cannot be just casted into an `Object[]` array. - The `BaseAdapter` class is now clear about the fact that it turns arrays into collections and not only iterables. If it doesn't do this, several things breaks downstream. This change also introduces two NoOp-Converter (`NoOpByteArrayConverter` and `NoOpWrappedByteArrayConverter`) that allow users to circumvent the conversion to Base64 arrays. We can read Base64 encoded into byte[] arrays from HTTP, but not write byte[] arrays over HTTP as the HTTP endpoint doesn’t support byte[] as parameter. This closes #791.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We optimized the previous
convertToIterable(nowiterableOfinCollectionUtilsto actually return an iterable. In the case of byte arrays, theEntityAccessManagercasts thatIterableinto a collection to coerce it with existing values. That lead to theClassCastExceptionmentioned in #791.The issue needs several fixes:
EntityAccessManagermust only work onIterablesCollectionUtilsmust treat an array of primitive types separatly. It cannot be just casted into anObject[]array.This change also introduces two NoOp-Converter (
NoOpByteArrayConverterandNoOpWrappedByteArrayConverter) that allow users to circumenvent the conversion to Base64 arrays.We can read Base64 encoded into byte[] arrays from HTTP, but not write byte[] arrays over HTTP as the HTTP endpoint doesn’t support byte[] as parameter.
This closes #791.