Improve nested filtering. #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows having OR’s in nested filters targeting the same entity. Thus, the entity itself works as a logical group and can itself by combined with filters on other properties with AND. A combination of filters with OR containing one nested filter is still not allowed. This commit makes the `NodeQueryBuilder` collapse deeply nested filters the same way as it does with normal ones.
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
============================================
+ Coverage 80.41% 80.48% +0.06%
- Complexity 3039 3043 +4
============================================
Files 277 277
Lines 9253 9273 +20
Branches 1381 1386 +5
============================================
+ Hits 7441 7463 +22
+ Misses 1303 1302 -1
+ Partials 509 508 -1
Continue to review full report at Codecov.
|
meistermeier
requested changes
Jun 5, 2020
core/src/main/java/org/neo4j/ogm/session/request/FilteredQueryBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/neo4j/ogm/session/request/FilteredQueryBuilder.java
Outdated
Show resolved
Hide resolved
michael-simons
added a commit
that referenced
this pull request
Jun 5, 2020
This change allows having OR’s in nested filters targeting the same entity. Thus, the entity itself works as a logical group and can itself by combined with filters on other properties with AND. A combination of filters with OR containing one nested filter is still not allowed. This commit makes the `NodeQueryBuilder` collapse deeply nested filters the same way as it does with normal ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows having OR’s in nested filters targeting the same entity. Thus, the entity itself works as a logical group and can itself by combined with filters on other properties with AND.
A combination of filters with OR containing one nested filter is still not allowed.
This commit makes the
NodeQueryBuildercollapse deeply nested filters the same way as it does with normal ones.