Improve handling of unknown generic types. #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the `SingleUseEntityMapper` to check the returned value for being something like a collection in case we couldn’t determine the generics of a wrapper class. In case the of Collections, this allows for a correct assigment.
Generic arrays are not detectable with that approach.
So something like
```
public class GenericQueryResultWrapper<T> {
T result;
}
```
will work for `T` being a known entity type or a collection thereof, but not for an array of known entities.
meistermeier
approved these changes
Jun 25, 2020
michael-simons
added a commit
that referenced
this pull request
Jul 3, 2020
This improves the `SingleUseEntityMapper` to check the returned value for being something like a collection in case we couldn’t determine the generics of a wrapper class. In case the of Collections, this allows for a correct assigment.
Generic arrays are not detectable with that approach.
So something like
```
public class GenericQueryResultWrapper<T> {
T result;
}
```
will work for `T` being a known entity type or a collection thereof, but not for an array of known entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
SingleUseEntityMapperto check the returned value for being something like a collection in case we couldn’t determine the generics of a wrapper class. In case the of Collections, this allows for a correct assigment.Generic arrays are not detectable with that approach.
So something like
will work for
Tbeing a known entity type or a collection thereof, but not for an array of known entities.