Make consistent use of mayBeReadWrite for deciding to clear the session or not. #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's perfect for me. All I needed is a way to prevent the Session clearing in this case, which this does. And it's even smart enough to figure out itself it's readonly in the most typical cases. Thanks, @michael-simons! I very much appreciate how you've been finding solutions for various use cases here. 👍 |
michael-simons
deleted the
issue/make-consistent-use-of-maybeReadWriteQuery
branch
|
@michael-simons 👍 it still works in my use case. Thanks for asking 😄 Is it possible to get a new release soon? |
|
Release 3.2.18 went out on Monday. |
|
In production since yesterday 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the following SDN issue: https://jira.spring.io/browse/DATAGRAPH-1407
Basically: The read only indicator of the transaction would overwrite any hint or other means to decide whether it's a rw or ro query. We cannot use it to decide to clear the session or not in a transaction spanning multiple queries.
@torstenkuhnhenne Would that still work with you use case?
Paging @Phoosha here as well.