Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toString() prevent compile errors #929

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

h1alexbel
Copy link
Contributor

Added @Override annotation on toString method to make a strict contract that has compile-time checks

@h1alexbel
Copy link
Contributor Author

Also, can we decompose the class MappedRelationship and introduce some more classes(objects)? Simply because this class encapsulates too many objects inside it.

@michael-simons
Copy link
Collaborator

This is nice, but I don't see that we have compile errors, merely warnings?

I'm happy to merge this, though, but can you please sign the CLA? https://neo4j.com/developer/cla/ and CC me michael.simons@neo4j.com

@h1alexbel
Copy link
Contributor Author

Signed, check it, please.

@michael-simons michael-simons self-assigned this Jan 16, 2023
@michael-simons michael-simons merged commit 5b85c2d into neo4j:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants