Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-952: OGM returns empty result if query results contains nodes and rels with same native id #953

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

nioertel
Copy link
Contributor

Description

This PR fixes GH-952

All existing tests are green via Maven.

There is still one issue with the newly created test - when ran separately it works but when ran together with the other tests, it currently fails as it's quite hard to set up the required test data when not starting with a clean Neo4j. I will think of a solution for that. However I wanted to already create the PR so you can let me know what you think about the fix.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

CLA

Signed.

@nioertel
Copy link
Contributor Author

The test for this issue/fix needs a clean Neo4j so that native ids for relationships and nodes start from 0 and are given consecutively without gaps within the test.
To work around this, I added a separate surefire execution to the integration-tests pom.xml so that this test gets its own JVM and own test container.

From my side the fix + test are ready - let me know what you think.

@michael-simons
Copy link
Collaborator

Oh man… Thanks for that, looks great. I'll merge away and probably polish afterwards.

@michael-simons michael-simons merged commit bbfbc3f into neo4j:3.2.x Jul 26, 2023
1 check passed
michael-simons added a commit that referenced this pull request Jul 26, 2023
…are only sort of unique for the respecting entity type. (#953)

Closes #592.

Co-authored-by: Michael Simons <michael.simons@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants