PR comments

neo4j · Jul 18, 2018 · 01ef8bf · 01ef8bf
1 parent 1253814
commit 01ef8bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/community/dbms/src/main/java/org/neo4j/commandline/dbms/DiagnosticsReportCommand.java b/community/dbms/src/main/java/org/neo4j/commandline/dbms/DiagnosticsReportCommand.java
@@ -66,7 +66,8 @@ public class DiagnosticsReportCommand implements AdminCommand
     private static final OptionalNamedArg destinationArgument =
             new OptionalCanonicalPath( "to", System.getProperty( "java.io.tmpdir" ), "reports" + File.separator,
                     "Destination directory for reports" );
-    private static final String PID_KEY = "pid";
+    public static final String PID_KEY = "pid";
+    private static final long NO_PID = 0;
     private static final Arguments arguments = new Arguments()
             .withArgument( new OptionalListArgument() )
             .withArgument( destinationArgument )
@@ -148,7 +149,7 @@ private static long parsePid( Args args ) throws CommandFailed
                 throw new CommandFailed( "Unable to parse --" + PID_KEY, e );
             }
         }
-        return 0;
+        return NO_PID;
     }
 
     private String getDefaultFilename() throws UnknownHostException
@@ -262,7 +263,7 @@ private DiagnosticsReporter createAndRegisterSources() throws CommandFailed
     private void registerJMXSources( DiagnosticsReporter reporter )
     {
         Optional<JmxDump> jmxDump;
-        if ( pid == 0 )
+        if ( pid == NO_PID )
         {
             jmxDump = jmxDumper.getJMXDump();
         }

diff --git a/community/dbms/src/main/java/org/neo4j/dbms/diagnostics/jmx/JMXDumper.java b/community/dbms/src/main/java/org/neo4j/dbms/diagnostics/jmx/JMXDumper.java
@@ -31,6 +31,8 @@
 
 import org.neo4j.io.fs.FileSystemAbstraction;
 
+import static org.neo4j.commandline.dbms.DiagnosticsReportCommand.PID_KEY;
+
 /**
  * Facilitates JMX Dump for current running Neo4j instance.
  */
@@ -63,7 +65,7 @@ public Optional<JmxDump> getJMXDump()
         else
         {
             out.println( "No running instance of neo4j was found. Online reports will be omitted." );
-            out.println( "If neo4j is running but not detected, you can supply the process id of the running instance with --pid" );
+            out.println( "If neo4j is running but not detected, you can supply the process id of the running instance with --" + PID_KEY );
             return Optional.empty();
         }
     }