Skip to content

Commit

Permalink
Replaced hard coded filename with Config.DEFAULT_CONFIG_FILE_NAME
Browse files Browse the repository at this point in the history
  • Loading branch information
klaren committed Aug 15, 2017
1 parent c0857d0 commit 0729574
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ private static Config loadNeo4jConfig( Path homeDir, Path configDir, String data
{
additionalConfig.put( DatabaseManagementSystemSettings.active_database.name(), databaseName );

return Config.fromFile( configDir.resolve( "neo4j.conf" ) ).withHome( homeDir ).withConnectorsDisabled()
return Config.fromFile( configDir.resolve( Config.DEFAULT_CONFIG_FILE_NAME ) ).withHome( homeDir ).withConnectorsDisabled()
.withSettings( additionalConfig ).build();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public void execute( String[] args ) throws IncorrectUsage, CommandFailed

private Path toDatabaseDirectory( String databaseName )
{
return Config.fromFile( configDir.resolve( "neo4j.conf" ) )
return Config.fromFile( configDir.resolve( Config.DEFAULT_CONFIG_FILE_NAME ) )
.withHome( homeDir )
.withConnectorsDisabled()
.withSetting( DatabaseManagementSystemSettings.active_database, databaseName )
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@
*/
package org.neo4j.backup;

import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
import java.io.PrintStream;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;

import org.hamcrest.BaseMatcher;
import org.hamcrest.Description;
import org.hamcrest.Matcher;
Expand All @@ -36,6 +28,14 @@
import org.junit.rules.ExpectedException;
import org.mockito.ArgumentCaptor;

import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
import java.io.PrintStream;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;

import org.neo4j.commandline.admin.CommandFailed;
import org.neo4j.commandline.admin.CommandLocator;
import org.neo4j.commandline.admin.IncorrectUsage;
Expand All @@ -53,7 +53,6 @@
import static java.util.concurrent.TimeUnit.HOURS;
import static java.util.concurrent.TimeUnit.MINUTES;
import static java.util.concurrent.TimeUnit.SECONDS;

import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThat;
Expand All @@ -68,7 +67,6 @@
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when;

import static org.neo4j.backup.OnlineBackupCommand.MAX_OLD_BACKUPS;
import static org.neo4j.backup.OnlineBackupCommand.STATUS_CC_ERROR;
import static org.neo4j.backup.OnlineBackupCommand.STATUS_CC_INCONSISTENT;
Expand Down Expand Up @@ -548,7 +546,7 @@ public void shouldReadStandardConfig() throws IOException, CommandFailed, Incorr
.ToolFailureException

{
Files.write( configDir.resolve( "neo4j.conf" ), singletonList( cypher_planner.name() + "=RULE" ) );
Files.write( configDir.resolve( Config.DEFAULT_CONFIG_FILE_NAME ), singletonList( cypher_planner.name() + "=RULE" ) );
ArgumentCaptor<Config> config = ArgumentCaptor.forClass( Config.class );

execute( backupDir(), "--name=mybackup" );
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.neo4j.desktop.Parameters;
import org.neo4j.desktop.config.Installation;
import org.neo4j.desktop.model.DesktopModel;
import org.neo4j.kernel.configuration.Config;
import org.neo4j.kernel.configuration.HttpConnector;
import org.neo4j.test.rule.TestDirectory;

Expand Down Expand Up @@ -79,7 +80,7 @@ public void createFiles() throws IOException
storeDir = new File( testDirectory.directory(), "store_dir" );
storeDir.mkdirs();

configFile = new File( testDirectory.directory(), "neo4j.conf" );
configFile = new File( testDirectory.directory(), Config.DEFAULT_CONFIG_FILE_NAME );
Properties props = new Properties();
props.setProperty( new HttpConnector( "http" ).type.name(), "HTTP" );
props.setProperty( new HttpConnector( "http" ).encryption.name(), "NONE" );
Expand Down

0 comments on commit 0729574

Please sign in to comment.