Review comments

neo4j · Mar 5, 2018 · 07fe97a · 07fe97a
1 parent 7c57510
commit 07fe97a
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 31 deletions.
diff --git a/community/values/src/main/java/org/neo4j/values/storable/DateTimeValue.java b/community/values/src/main/java/org/neo4j/values/storable/DateTimeValue.java
@@ -390,12 +390,6 @@ public ValueGroup valueGroup()
         return ValueGroup.ZONED_DATE_TIME;
     }
 
-    @Override
-    public String toString()
-    {
-        return prettyPrint();
-    }
-
     @Override
     protected int computeHash()
     {

diff --git a/community/values/src/main/java/org/neo4j/values/storable/DateValue.java b/community/values/src/main/java/org/neo4j/values/storable/DateValue.java
@@ -193,12 +193,6 @@ public ValueGroup valueGroup()
         return ValueGroup.DATE;
     }
 
-    @Override
-    public String toString()
-    {
-        return prettyPrint();
-    }
-
     @Override
     protected int computeHash()
     {

diff --git a/community/values/src/main/java/org/neo4j/values/storable/LocalDateTimeValue.java b/community/values/src/main/java/org/neo4j/values/storable/LocalDateTimeValue.java
@@ -309,12 +309,6 @@ public ValueGroup valueGroup()
         return ValueGroup.LOCAL_DATE_TIME;
     }
 
-    @Override
-    public String toString()
-    {
-        return prettyPrint();
-    }
-
     @Override
     protected int computeHash()
     {

diff --git a/community/values/src/main/java/org/neo4j/values/storable/LocalTimeValue.java b/community/values/src/main/java/org/neo4j/values/storable/LocalTimeValue.java
@@ -230,12 +230,6 @@ public ValueGroup valueGroup()
         return ValueGroup.LOCAL_TIME;
     }
 
-    @Override
-    public String toString()
-    {
-        return prettyPrint();
-    }
-
     @Override
     protected int computeHash()
     {

diff --git a/community/values/src/main/java/org/neo4j/values/storable/TemporalValue.java b/community/values/src/main/java/org/neo4j/values/storable/TemporalValue.java
@@ -206,6 +206,12 @@ public final boolean equals( String x )
         return false;
     }
 
+    @Override
+    public String toString()
+    {
+        return prettyPrint();
+    }
+
     static <VALUE> VALUE parse( Class<VALUE> type, Pattern pattern, Function<Matcher,VALUE> parser, CharSequence text )
     {
         Matcher matcher = pattern.matcher( text );

diff --git a/community/values/src/main/java/org/neo4j/values/storable/TimeValue.java b/community/values/src/main/java/org/neo4j/values/storable/TimeValue.java
@@ -269,12 +269,6 @@ public ValueGroup valueGroup()
         return ValueGroup.ZONED_TIME;
     }
 
-    @Override
-    public String toString()
-    {
-        return prettyPrint();
-    }
-
     @Override
     protected int computeHash()
     {

diff --git a/...her/spec-suite-tools/src/test/scala/cypher/features/Neo4jExceptionToExecutionFailed.scala b/...her/spec-suite-tools/src/test/scala/cypher/features/Neo4jExceptionToExecutionFailed.scala
@@ -32,8 +32,8 @@ object Neo4jExceptionToExecutionFailed {
 
   def convert(phase: String, t: Throwable): ExecutionFailed = {
     val neo4jException = t match {
-      case _ => throw t
       case re: RuntimeException => re
+      case _ => throw t
     }
     val errorType = Status.statusCodeOf(neo4jException)
     val msg = neo4jException.getMessage