Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
d40c13b
commit 0814026
Showing
9 changed files
with
219 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
community/kernel/src/main/java/org/neo4j/kernel/impl/api/store/EntityLoadingIterator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Copyright (c) 2002-2017 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Neo4j is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package org.neo4j.kernel.impl.api.store; | ||
|
|
||
| import org.neo4j.collection.primitive.PrimitiveLongIterator; | ||
| import org.neo4j.cursor.Cursor; | ||
| import org.neo4j.function.ThrowingLongFunction; | ||
| import org.neo4j.helpers.collection.PrefetchingIterator; | ||
| import org.neo4j.kernel.api.exceptions.EntityNotFoundException; | ||
| import org.neo4j.storageengine.api.EntityItem; | ||
|
|
||
| public class EntityLoadingIterator<T extends EntityItem> extends PrefetchingIterator<Cursor<T>> | ||
| { | ||
| private final PrimitiveLongIterator ids; | ||
| private final ThrowingLongFunction<Cursor<T>,EntityNotFoundException> loader; | ||
|
|
||
| public EntityLoadingIterator( PrimitiveLongIterator ids, | ||
| ThrowingLongFunction<Cursor<T>,EntityNotFoundException> loader ) | ||
| { | ||
| this.ids = ids; | ||
| this.loader = loader; | ||
| } | ||
|
|
||
| @Override | ||
| protected Cursor<T> fetchNextOrNull() | ||
| { | ||
| while ( ids.hasNext() ) | ||
| { | ||
| try | ||
| { | ||
| return loader.apply( ids.next() ); | ||
| } | ||
| catch ( EntityNotFoundException e ) | ||
| { | ||
| // skip this id | ||
| } | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
...unity/kernel/src/test/java/org/neo4j/kernel/impl/api/store/EntityLoadingIteratorTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| /* | ||
| * Copyright (c) 2002-2017 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Neo4j is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package org.neo4j.kernel.impl.api.store; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.NoSuchElementException; | ||
|
|
||
| import org.neo4j.collection.primitive.PrimitiveLongCollections; | ||
| import org.neo4j.collection.primitive.PrimitiveLongIterator; | ||
| import org.neo4j.cursor.Cursor; | ||
| import org.neo4j.function.ThrowingLongFunction; | ||
| import org.neo4j.kernel.api.exceptions.EntityNotFoundException; | ||
| import org.neo4j.storageengine.api.EntityItem; | ||
| import org.neo4j.storageengine.api.EntityType; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.neo4j.collection.primitive.PrimitiveLongCollections.emptyIterator; | ||
|
|
||
| public class EntityLoadingIteratorTest | ||
| { | ||
| @Test | ||
| public void shouldHandleAnEmptyIterator() throws Exception | ||
| { | ||
| // given | ||
| EntityLoadingIterator<EntityItem> iterator = new EntityLoadingIterator<>( emptyIterator(), ( id ) -> | ||
| { | ||
| throw new IllegalStateException( "" ); | ||
| } ); | ||
|
|
||
| // when - then | ||
| assertNoMoreElements( iterator ); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldHandleANonEmptyIterator() throws Exception | ||
| { | ||
| // given | ||
| Map<Long,Cursor<EntityItem>> map = new HashMap<>( 3 ); | ||
| map.put( 1L, mockCursor() ); | ||
| map.put( 2L, mockCursor() ); | ||
| map.put( 3L, mockCursor() ); | ||
| PrimitiveLongIterator inner = PrimitiveLongCollections.iterator( 1, 2, 3 ); | ||
| EntityLoadingIterator<EntityItem> iterator = new EntityLoadingIterator<>( inner, createMapping( map ) ); | ||
|
|
||
| // when - then | ||
| for ( long i = 1; i <= 3; i++) | ||
| { | ||
| assertTrue( iterator.hasNext() ); | ||
| assertEquals( map.get( i ), iterator.next() ); | ||
| } | ||
|
|
||
| assertNoMoreElements( iterator ); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldHandleANonEmptyIteratorWithNotFoundEntities() throws Exception | ||
| { | ||
| // given | ||
| Map<Long,Cursor<EntityItem>> map = new HashMap<>( 3 ); | ||
| map.put( 1L, mockCursor() ); | ||
| map.put( 2L, null ); | ||
| map.put( 3L, mockCursor() ); | ||
| PrimitiveLongIterator inner = PrimitiveLongCollections.iterator( 1, 2, 3 ); | ||
| EntityLoadingIterator<EntityItem> iterator = new EntityLoadingIterator<>( inner, createMapping( map ) ); | ||
|
|
||
| // when - then | ||
| for ( long i = 1; i <= 2; i++) | ||
| { | ||
| assertTrue( iterator.hasNext() ); | ||
|
|
||
| assertEquals( map.get( i + (i - 1) /* 1 -> 1, 2 -> 3 */ ), iterator.next() ); | ||
| } | ||
|
|
||
| assertNoMoreElements( iterator ); | ||
| } | ||
|
|
||
| private void assertNoMoreElements( EntityLoadingIterator<EntityItem> iterator ) | ||
| { | ||
| assertFalse( iterator.hasNext() ); | ||
| try | ||
| { | ||
| iterator.next(); | ||
| fail( "should have thrown "); | ||
| } | ||
| catch ( NoSuchElementException e ) | ||
| { | ||
| // good | ||
| } | ||
| } | ||
|
|
||
| private ThrowingLongFunction<Cursor<EntityItem>,EntityNotFoundException> createMapping( | ||
| Map<Long,Cursor<EntityItem>> map ) | ||
| { | ||
| return ( id ) -> | ||
| { | ||
| if ( !map.containsKey( id ) ) | ||
| { | ||
| throw new IllegalStateException( "wat!?" ); | ||
| } | ||
| Cursor<EntityItem> cursor = map.get( id ); | ||
| if ( cursor == null ) | ||
| { | ||
| throw new EntityNotFoundException( EntityType.NODE, id ); | ||
| } | ||
| return cursor; | ||
| }; | ||
| } | ||
|
|
||
| @SuppressWarnings( "unchecked" ) | ||
| private Cursor<EntityItem> mockCursor() | ||
| { | ||
| return (Cursor<EntityItem>) mock( Cursor.class ); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters