Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed unreachable code & minor refactoring in PropertyLoader
- Loading branch information
Showing
2 changed files
with
191 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
187 changes: 187 additions & 0 deletions
187
...nity/kernel/src/test/java/org/neo4j/kernel/impl/transaction/state/PropertyLoaderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| /** | ||
| * Copyright (c) 2002-2015 "Neo Technology," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Neo4j is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package org.neo4j.kernel.impl.transaction.state; | ||
|
|
||
| import org.junit.Before; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import org.neo4j.kernel.impl.core.IteratingPropertyReceiver; | ||
| import org.neo4j.kernel.impl.store.AbstractRecordStore; | ||
| import org.neo4j.kernel.impl.store.InvalidRecordException; | ||
| import org.neo4j.kernel.impl.store.NeoStore; | ||
| import org.neo4j.kernel.impl.store.NodeStore; | ||
| import org.neo4j.kernel.impl.store.PropertyStore; | ||
| import org.neo4j.kernel.impl.store.RelationshipStore; | ||
| import org.neo4j.kernel.impl.store.record.NodeRecord; | ||
| import org.neo4j.kernel.impl.store.record.PrimitiveRecord; | ||
| import org.neo4j.kernel.impl.store.record.PropertyBlock; | ||
| import org.neo4j.kernel.impl.store.record.PropertyRecord; | ||
| import org.neo4j.kernel.impl.store.record.RelationshipRecord; | ||
| import org.neo4j.test.EmbeddedDatabaseRule; | ||
|
|
||
| import static java.util.Arrays.asList; | ||
| import static org.hamcrest.Matchers.startsWith; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertThat; | ||
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.neo4j.helpers.collection.Iterables.toList; | ||
| import static org.neo4j.kernel.api.properties.DefinedProperty.intProperty; | ||
|
|
||
| public class PropertyLoaderTest | ||
| { | ||
| private static final int PROP_KEY_ID = 42; | ||
|
|
||
| @Rule | ||
| public final EmbeddedDatabaseRule db = new EmbeddedDatabaseRule(); | ||
|
|
||
| private final IteratingPropertyReceiver receiver = new IteratingPropertyReceiver(); | ||
|
|
||
| private final NeoStore neoStore = mock( NeoStore.class ); | ||
| private final NodeStore nodeStore = mock( NodeStore.class ); | ||
| private final RelationshipStore relationshipStore = mock( RelationshipStore.class ); | ||
| private final PropertyStore propertyStore = mock( PropertyStore.class ); | ||
|
|
||
| @Before | ||
| public void setUpMocking() throws Exception | ||
| { | ||
| doReturn( nodeStore ).when( neoStore ).getNodeStore(); | ||
| doReturn( relationshipStore ).when( neoStore ).getRelationshipStore(); | ||
| doReturn( propertyStore ).when( neoStore ).getPropertyStore(); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldThrowForNotInUseNodeRecord() | ||
| { | ||
| // Given | ||
| PropertyLoader loader = new PropertyLoader( neoStore() ); | ||
|
|
||
| try | ||
| { | ||
| // When | ||
| loader.nodeLoadProperties( 42, receiver ); | ||
| } | ||
| catch ( InvalidRecordException e ) | ||
| { | ||
| // Then | ||
| assertThat( e.getMessage(), startsWith( "NodeRecord" ) ); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldThrowForNotInUseRelationshipRecord() | ||
| { | ||
| // Given | ||
| PropertyLoader loader = new PropertyLoader( neoStore() ); | ||
|
|
||
| try | ||
| { | ||
| // When | ||
| loader.relLoadProperties( 42, receiver ); | ||
| } | ||
| catch ( InvalidRecordException e ) | ||
| { | ||
| // Then | ||
| assertThat( e.getMessage(), startsWith( "RelationshipRecord" ) ); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldReturnCorrectPropertyChainForNode() | ||
| { | ||
| // Given | ||
| setUpNode( 42, 1, 2, 3 ); | ||
| PropertyLoader loader = new PropertyLoader( neoStore ); | ||
|
|
||
| // When | ||
| loader.nodeLoadProperties( 42, receiver ); | ||
|
|
||
| // Then | ||
| assertEquals( | ||
| asList( intProperty( PROP_KEY_ID, 1 ), intProperty( PROP_KEY_ID, 2 ), intProperty( PROP_KEY_ID, 3 ) ), | ||
| toList( receiver ) ); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldReturnCorrectPropertyChainForRelationship() | ||
| { | ||
| // Given | ||
| setUpRelationship( 42, 1111, 2222 ); | ||
| PropertyLoader loader = new PropertyLoader( neoStore ); | ||
|
|
||
| // When | ||
| loader.relLoadProperties( 42, receiver ); | ||
|
|
||
| // Then | ||
| assertEquals( | ||
| asList( intProperty( PROP_KEY_ID, 1111 ), intProperty( PROP_KEY_ID, 2222 ) ), | ||
| toList( receiver ) ); | ||
| } | ||
|
|
||
| private NeoStore neoStore() | ||
| { | ||
| return db.getGraphDatabaseAPI().getDependencyResolver().resolveDependency( NeoStore.class ); | ||
| } | ||
|
|
||
| private void setUpNode( long id, int... propertyValues ) | ||
| { | ||
| setUpPropertyChain( id, NodeRecord.class, nodeStore, propertyValues ); | ||
| } | ||
|
|
||
| private void setUpRelationship( long id, int... propertyValues ) | ||
| { | ||
| setUpPropertyChain( id, RelationshipRecord.class, relationshipStore, propertyValues ); | ||
| } | ||
|
|
||
| private <R extends PrimitiveRecord> void setUpPropertyChain( long id, Class<R> recordClass, | ||
| AbstractRecordStore<R> store, int... propertyValues ) | ||
| { | ||
| R record = mock( recordClass ); | ||
| doReturn( id ).when( record ).getId(); | ||
| doReturn( 1L ).when( record ).getNextProp(); | ||
| doReturn( record ).when( store ).getRecord( id ); | ||
| List<PropertyRecord> propertyChain = new ArrayList<>( propertyValues.length ); | ||
| for ( int i = 0; i < propertyValues.length; i++ ) | ||
| { | ||
| propertyChain.add( newSingleIntProperty( i + 1, propertyValues[i] ) ); | ||
| } | ||
| doReturn( propertyChain ).when( propertyStore ).getPropertyRecordChain( 1L ); | ||
| } | ||
|
|
||
| private static PropertyRecord newSingleIntProperty( long id, int value ) | ||
| { | ||
| PropertyRecord record = new PropertyRecord( id ); | ||
| record.setInUse( true ); | ||
| record.addPropertyBlock( newSingleIntPropertyBlock( value ) ); | ||
| return record; | ||
| } | ||
|
|
||
| private static PropertyBlock newSingleIntPropertyBlock( int value ) | ||
| { | ||
| PropertyBlock block = new PropertyBlock(); | ||
| PropertyStore.encodeValue( block, PROP_KEY_ID, value, null, null ); | ||
| block.setKeyIndexId( PROP_KEY_ID ); | ||
| return block; | ||
| } | ||
| } |