Skip to content

Commit

Permalink
Cleanup TCK implementation
Browse files Browse the repository at this point in the history
- remove unused config file (compiled runtime)
- rename classes and files to clarify configurations (only planners)
- use named constants to clarify purpose of string arguments
  • Loading branch information
Mats-SX committed May 31, 2016
1 parent 95389f3 commit 0e46271
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 18 deletions.
Expand Up @@ -37,32 +37,41 @@ public class FeatureSuiteTest
@RunWith( Cucumber.class )
@CucumberOptions(
plugin = {
"html:target/rule-interpreted",
"cypher.feature.reporting.CypherResultReporter:target/rule-interpreted",
"cypher.cucumber.db.DatabaseProvider:target/dbs",
"cypher.cucumber.db.DatabaseConfigProvider:/cypher/db/config/rule.json"
NAMED_GRAPHS_DBS,
DB_CONFIG + "rule.json",
HTML_REPORT + "rule",
JSON_REPORT + "rule"
},
glue = { "classpath:cypher/feature/steps" },
features = { "target/features/" + FEATURE_TO_RUN },
glue = { GLUE_PATH },
features = { FEATURE_PATH + FEATURE_TO_RUN },
strict = true
)
public static class RuleInterpreted
public static class Rule
{
}

@RunWith( Cucumber.class )
@CucumberOptions(
plugin = {
"html:target/cost-interpreted",
"cypher.feature.reporting.CypherResultReporter:target/cost-interpreted",
"cypher.cucumber.db.DatabaseProvider:target/dbs",
"cypher.cucumber.db.DatabaseConfigProvider:/cypher/db/config/cost-interpreted.json",
NAMED_GRAPHS_DBS,
DB_CONFIG + "cost.json",
HTML_REPORT + "cost",
JSON_REPORT + "cost"
},
glue = { "classpath:cypher/feature/steps" },
features = { "target/features/" + FEATURE_TO_RUN },
glue = { GLUE_PATH },
features = { FEATURE_PATH + FEATURE_TO_RUN },
strict = true
)
public static class CostInterpreted
public static class Cost
{
}

// constants for TCK configuration

private static final String NAMED_GRAPHS_DBS = "cypher.cucumber.db.DatabaseProvider:target/dbs";
private static final String DB_CONFIG = "cypher.cucumber.db.DatabaseConfigProvider:/cypher/db/config/";
private static final String HTML_REPORT = "html:target/";
private static final String JSON_REPORT = "cypher.feature.reporting.CypherResultReporter:target/";
private static final String GLUE_PATH = "classpath:cypher/feature/steps";
private static final String FEATURE_PATH = "target/features/";
}

This file was deleted.

0 comments on commit 0e46271

Please sign in to comment.