Fulltext addon cleanup

enterprise/fulltext-helper/src/main/java/org/neo4j/kernel/api/impl/fulltext/BloomDocumentStructure.java → enterprise/fulltext-addon/src/main/java/org/neo4j/kernel/api/impl/fulltext/FulltextHelperDocumentStructure.java

@@ -32,15 +32,16 @@
 import org.neo4j.values.storable.Value;
 import org.neo4j.values.storable.Values;
 
+import static org.apache.lucene.document.Field.Store.NO;
 import static org.apache.lucene.document.Field.Store.YES;
 
-class BloomDocumentStructure
+class FulltextHelperDocumentStructure
 {
     static final String ID_KEY = "id";
 
     private static final ThreadLocal<DocWithId> perThreadDocument = ThreadLocal.withInitial( DocWithId::new );
 
-    private BloomDocumentStructure()
+    private FulltextHelperDocumentStructure()
     {
     }
 
@@ -58,11 +59,6 @@ public static Document documentRepresentingProperties( long id, Map<String,Objec
         return document.document;
     }
 
-    public static long getNodeId( Document from )
-    {
-        return Long.parseLong( from.get( ID_KEY ) );
-    }
-
     static Field encodeValueField( String propertyKey, Value value )
     {
         return BloomFieldEncoding.encodeField( propertyKey, value );
@@ -77,7 +73,7 @@ private static class DocWithId
 
         private DocWithId()
         {
-            idField = new StringField( ID_KEY, "", YES );
+            idField = new StringField( ID_KEY, "", NO );
             idValueField = new NumericDocValuesField( ID_KEY, 0L );
             document = new Document();
             document.add( idField );

enterprise/fulltext-helper/src/main/java/org/neo4j/kernel/api/impl/fulltext/FulltextHelperFactory.java → enterprise/fulltext-addon/src/main/java/org/neo4j/kernel/api/impl/fulltext/FulltextHelperFactory.java

@@ -38,12 +38,12 @@
 
 public class FulltextHelperFactory
 {
-    private FileSystemAbstraction fileSystem;
+    private final FileSystemAbstraction fileSystem;
     private final String[] properties;
     private final WritableIndexPartitionFactory partitionFactory;
     private final Factory<IndexWriterConfig> population;
     private final File storeDir;
-    private Analyzer analyzer;
+    private final Analyzer analyzer;
 
     public LuceneFulltextHelper createFulltextHelper( String identifier, FULLTEXT_HELPER_TYPE type )
     {

enterprise/fulltext-helper/src/main/java/org/neo4j/kernel/api/impl/fulltext/bloom/integration/BloomKernelExtension.java → enterprise/fulltext-addon/src/main/java/org/neo4j/kernel/api/impl/fulltext/integrations/bloom/BloomKernelExtension.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.kernel.api.impl.fulltext.bloom.integration;
+package org.neo4j.kernel.api.impl.fulltext.integrations.bloom;
 
 import java.io.File;
 import java.io.IOException;
@@ -56,9 +56,9 @@ public void init() throws IOException, ProcedureException
         FulltextHelperProvider provider = FulltextHelperProvider.instance( db );
         fulltextHelperFactory = new FulltextHelperFactory( fileSystemAbstraction, storeDir, config );
         LuceneFulltextHelper nodes = fulltextHelperFactory.createFulltextHelper( "bloomNodes", FulltextHelperFactory.FULLTEXT_HELPER_TYPE.NODES );
-        provider.register( nodes );
         LuceneFulltextHelper relationships =
                 fulltextHelperFactory.createFulltextHelper( "bloomRelationships", FulltextHelperFactory.FULLTEXT_HELPER_TYPE.RELATIONSHIPS );
+        provider.register( nodes );
         provider.register( relationships );
 
         procedures.register( new BloomProcedure( "Nodes", nodes ) );

enterprise/fulltext-helper/src/main/java/org/neo4j/kernel/api/impl/fulltext/bloom/integration/BloomKernelExtensionFactory.java → enterprise/fulltext-addon/src/main/java/org/neo4j/kernel/api/impl/fulltext/integrations/bloom/BloomKernelExtensionFactory.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.kernel.api.impl.fulltext.bloom.integration;
+package org.neo4j.kernel.api.impl.fulltext.integrations.bloom;
 
 import org.neo4j.graphdb.GraphDatabaseService;
 import org.neo4j.io.fs.FileSystemAbstraction;

enterprise/fulltext-helper/src/main/java/org/neo4j/kernel/api/impl/fulltext/bloom/integration/BloomProcedure.java → enterprise/fulltext-addon/src/main/java/org/neo4j/kernel/api/impl/fulltext/integrations/bloom/BloomProcedure.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.kernel.api.impl.fulltext.bloom.integration;
+package org.neo4j.kernel.api.impl.fulltext.integrations.bloom;
 
 import java.util.Arrays;
 

enterprise/fulltext-helper/src/test/java/org/neo4j/kernel/api/impl/fulltext/bloom/integration/BloomIT.java → enterprise/fulltext-addon/src/test/java/org/neo4j/kernel/api/impl/fulltext/integrations/bloom/BloomIT.java

@@ -17,7 +17,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-package org.neo4j.kernel.api.impl.fulltext.bloom.integration;
+package org.neo4j.kernel.api.impl.fulltext.integrations.bloom;
 
 import org.junit.After;
 import org.junit.Before;

enterprise/pom.xml

@@ -46,7 +46,7 @@
     <module>deferred-locks</module>
     <module>ha</module>
     <module>procedure-compiler-enterprise-tests</module>
-    <module>fulltext-helper</module>
+    <module>fulltext-addon</module>
   </modules>
 
   <profiles>