-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Native index validate correct string length
- Loading branch information
Showing
4 changed files
with
133 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
...e-index/src/test/java/org/neo4j/kernel/api/impl/schema/StringLengthIndexValidationIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* | ||
| * Copyright (c) 2002-2018 "Neo4j," | ||
| * Neo4j Sweden AB [http://neo4j.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Neo4j is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package org.neo4j.kernel.api.impl.schema; | ||
|
|
||
| import org.hamcrest.Matchers; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import org.neo4j.graphdb.Node; | ||
| import org.neo4j.graphdb.Transaction; | ||
| import org.neo4j.graphdb.factory.GraphDatabaseSettings; | ||
| import org.neo4j.index.internal.gbptree.TreeNodeDynamicSize; | ||
| import org.neo4j.io.pagecache.PageCache; | ||
| import org.neo4j.test.rule.DatabaseRule; | ||
| import org.neo4j.test.rule.EmbeddedDatabaseRule; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertThat; | ||
| import static org.neo4j.test.TestLabels.LABEL_ONE; | ||
|
|
||
| public class StringLengthIndexValidationIT | ||
| { | ||
| @Rule | ||
| public DatabaseRule db = new EmbeddedDatabaseRule() | ||
| .withSetting( GraphDatabaseSettings.default_schema_provider, GraphDatabaseSettings.SchemaIndex.NATIVE20.providerName() ); | ||
|
|
||
| private static final String propKey = "largeString"; | ||
| private static final int keySizeLimit = TreeNodeDynamicSize.keyValueSizeCapFromPageSize( PageCache.PAGE_SIZE ) - Long.BYTES; | ||
|
|
||
| @Test | ||
| public void shouldSuccessfullyWriteAndReadWithinIndexKeySizeLimit() | ||
| { | ||
| createIndex(); | ||
| String propValue = getString( keySizeLimit ); | ||
| long expectedNodeId; | ||
|
|
||
| // Write | ||
| try ( Transaction tx = db.beginTx() ) | ||
| { | ||
| Node node = db.createNode( LABEL_ONE ); | ||
| node.setProperty( propKey, propValue ); | ||
| expectedNodeId = node.getId(); | ||
| tx.success(); | ||
| } | ||
|
|
||
| // Read | ||
| try ( Transaction tx = db.beginTx() ) | ||
| { | ||
| Node node = db.findNode( LABEL_ONE, propKey, propValue ); | ||
| assertNotNull( node ); | ||
| assertEquals( "node id", expectedNodeId, node.getId() ); | ||
| tx.success(); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void txMustFailIfExceedingIndexKeySizeLimit() | ||
| { | ||
| createIndex(); | ||
|
|
||
| // Write | ||
| try ( Transaction tx = db.beginTx() ) | ||
| { | ||
| String propValue = getString( keySizeLimit + 1 ); | ||
| db.createNode( LABEL_ONE ).setProperty( propKey, propValue ); | ||
| tx.success(); | ||
| } | ||
| catch ( IllegalArgumentException e ) | ||
| { | ||
| assertThat( e.getMessage(), Matchers.containsString( String.format( | ||
| "Property value bytes length: %d is longer than %d, which is maximum supported length of indexed property value", keySizeLimit + 1, keySizeLimit ) ) ); | ||
| } | ||
| } | ||
|
|
||
| private String getString( int stringSize ) | ||
| { | ||
| StringBuilder buf = new StringBuilder(); | ||
| for ( int i = 0; i < stringSize; i++ ) | ||
| { | ||
| buf.append( "0" ); | ||
| } | ||
| return buf.toString(); | ||
| } | ||
|
|
||
| private void createIndex() | ||
| { | ||
| try ( Transaction tx = db.beginTx() ) | ||
| { | ||
| db.schema().indexFor( LABEL_ONE ).on( propKey ).create(); | ||
| tx.success(); | ||
| } | ||
| try ( Transaction tx = db.beginTx() ) | ||
| { | ||
| db.schema().awaitIndexesOnline( 1, TimeUnit.MINUTES ); | ||
| tx.success(); | ||
| } | ||
| } | ||
| } |