Merge pull request #5892 from davidegrohmann/2.3-deprecate-single-csv…

…-metrics-reporter

Deprecate metrics reporting into a single csv file

enterprise/metrics/src/main/java/org/neo4j/metrics/MetricsSettings.java

@@ -26,6 +26,7 @@
 import org.neo4j.graphdb.factory.GraphDatabaseSettings;
 import org.neo4j.helpers.HostnamePort;
 import org.neo4j.helpers.Settings;
+import org.neo4j.kernel.configuration.Obsoleted;
 
 import static org.neo4j.helpers.Settings.basePath;
 import static org.neo4j.helpers.Settings.setting;
@@ -101,6 +102,8 @@ public enum CsvFile
                   "will be intepreted relative to the configured Neo4j store directory." )
     public static Setting<File> csvPath = setting(
             "metrics.csv.path", Settings.PATH, "metrics.csv" , basePath( GraphDatabaseSettings.store_dir ) );
+    @Deprecated
+    @Obsoleted( "This setting will be removed in the next major release." )
     @Description( "Write to a single CSV file or to multiple files. " +
                   "Set to `single` (the default) for reporting the metrics in a single CSV file (given by " +
                   "metrics.csv.path), with a column per metrics field. Or set to `split` to produce a CSV file for " +

enterprise/metrics/src/main/java/org/neo4j/metrics/output/CsvReporterSingle.java

@@ -48,7 +48,11 @@
  * Version of CSV reporter that logs all metrics into a single file.
  * Restriction is that all metrics must be set up before starting it,
  * as it cannot handle changing sets of metrics at runtime.
+ *
+ * @deprecated please use {@code com.codahale.metrics.CsvReporter} instead. This reporter is incompatible with the
+ * event based reporting that will be introduced in the next major release, hence it will be removed.
  */
+@Deprecated
 public class CsvReporterSingle extends ScheduledReporter
 {
     // CSV separator