Improve tests by awaiting new master before continuing

neo4j · Jul 1, 2016 · 36a5fb5 · 36a5fb5
1 parent 2f427e4
commit 36a5fb5
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/enterprise/ha/src/test/java/org/neo4j/ha/TransactionConstraintsIT.java b/enterprise/ha/src/test/java/org/neo4j/ha/TransactionConstraintsIT.java
@@ -109,12 +109,13 @@ public void startTxAsSlaveAndFinishItAfterHavingSwitchedToMasterShouldNotSucceed
         }
         finally
         {
-            cluster.shutdown( cluster.getMaster() );
+            HighlyAvailableGraphDatabase oldMaster = cluster.getMaster();
+            cluster.shutdown( oldMaster );
+            // Wait for new master
+            cluster.await( masterAvailable( oldMaster ) );
             assertFinishGetsTransactionFailure( tx );
         }
 
-        cluster.await( masterAvailable() );
-
         // THEN
         assertEquals( db, cluster.getMaster() );
         // to prevent a deadlock scenario which occurs if this test exists (and @After starts)
@@ -127,7 +128,7 @@ public void startTxAsSlaveAndFinishItAfterAnotherMasterBeingAvailableShouldNotSu
     {
         // GIVEN
         HighlyAvailableGraphDatabase db = getSlaveOnlySlave();
-        HighlyAvailableGraphDatabase oldMaster = cluster.getMaster();
+        HighlyAvailableGraphDatabase oldMaster;
 
         // WHEN
         Transaction tx = db.beginTx();
@@ -138,18 +139,14 @@ public void startTxAsSlaveAndFinishItAfterAnotherMasterBeingAvailableShouldNotSu
         }
         finally
         {
+            oldMaster = cluster.getMaster();
             cluster.shutdown( oldMaster );
+            // Wait for new master
+            cluster.await( masterAvailable( oldMaster ) );
             // THEN
             assertFinishGetsTransactionFailure( tx );
         }
 
-        try
-        {
-            cluster.await( ClusterManager.masterAvailable() );
-        } catch (Exception e) {
-            throw e;
-        }
-
         assertFalse( db.isMaster() );
         assertFalse( oldMaster.isMaster() );
         // to prevent a deadlock scenario which occurs if this test exists (and @After starts)