Abstract LabelScanStoreChaosIT, implemented by Lucene

LuceneLabelScanStoreChaosIT extends abstract LabelScanStoreChaosIT
Other LabelScanStore implementations should also use LabelScanStoreChaosIT

community/kernel/src/test/java/org/neo4j/graphdb/LabelScanStoreChaosIT.java

@@ -0,0 +1,107 @@
+/*
+ * Copyright (c) 2002-2016 "Neo Technology,"
+ * Network Engine for Objects in Lund AB [http://neotechnology.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Neo4j is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package org.neo4j.graphdb;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.RuleChain;
+
+import java.util.Set;
+
+import org.neo4j.test.rule.DatabaseRule;
+import org.neo4j.test.rule.EmbeddedDatabaseRule;
+import org.neo4j.test.rule.RandomRule;
+
+import static org.junit.Assert.assertEquals;
+import static org.neo4j.helpers.collection.Iterators.asSet;
+
+/**
+ * Tests functionality around missing or corrupted lucene label scan store index, and that
+ * the database should repair (i.e. rebuild) that automatically and just work.
+ */
+public abstract class LabelScanStoreChaosIT
+{
+    private final DatabaseRule dbRule = new EmbeddedDatabaseRule( getClass() );
+    protected final RandomRule randomRule = new RandomRule();
+    @Rule
+    public final RuleChain ruleChain = RuleChain.outerRule( randomRule ).around( dbRule );
+
+    @Test
+    public void shouldRebuildDeletedLabelScanStoreOnStartup() throws Exception
+    {
+        // GIVEN
+        Node node1 = createLabeledNode( Labels.First );
+        Node node2 = createLabeledNode( Labels.First );
+        Node node3 = createLabeledNode( Labels.First );
+        deleteNode( node2 ); // just to create a hole in the store
+
+        // WHEN
+        dbRule.restartDatabase( deleteTheLabelScanStoreIndex() );
+
+        // THEN
+        assertEquals( asSet( node1, node3 ), getAllNodesWithLabel( Labels.First ) );
+    }
+
+    @Test
+    public void rebuildCorruptedLabelScanStoreToStartup() throws Exception
+    {
+        Node node = createLabeledNode( Labels.First );
+
+        dbRule.restartDatabase( corruptTheLabelScanStoreIndex() );
+
+        assertEquals( asSet( node ), getAllNodesWithLabel( Labels.First ) );
+    }
+
+    protected abstract DatabaseRule.RestartAction corruptTheLabelScanStoreIndex();
+
+    protected abstract DatabaseRule.RestartAction deleteTheLabelScanStoreIndex();
+
+    private Node createLabeledNode( Label... labels )
+    {
+        try ( Transaction tx = dbRule.getGraphDatabaseAPI().beginTx() )
+        {
+            Node node = dbRule.getGraphDatabaseAPI().createNode( labels );
+            tx.success();
+            return node;
+        }
+    }
+
+    private Set<Node> getAllNodesWithLabel( Label label )
+    {
+        try ( Transaction tx = dbRule.getGraphDatabaseAPI().beginTx() )
+        {
+            return asSet( dbRule.getGraphDatabaseAPI().findNodes( label ) );
+        }
+    }
+
+    private void deleteNode( Node node )
+    {
+        try ( Transaction tx = dbRule.getGraphDatabaseAPI().beginTx() )
+        {
+            node.delete();
+            tx.success();
+        }
+    }
+
+    private enum Labels implements Label
+    {
+        First, Second, Third
+    }
+}

community/lucene-index/src/test/java/org/neo4j/graphdb/LuceneLabelScanStoreChaosIT.java

@@ -19,67 +19,26 @@
  */
 package org.neo4j.graphdb;
 
-import org.junit.Rule;
-import org.junit.Test;
-
 import java.io.File;
 import java.io.IOException;
 import java.io.RandomAccessFile;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
 import java.util.Collections;
 import java.util.List;
-import java.util.Random;
-import java.util.Set;
 import java.util.stream.Stream;
 
 import org.neo4j.kernel.api.impl.labelscan.LuceneLabelScanIndexBuilder;
 import org.neo4j.test.rule.DatabaseRule;
-import org.neo4j.test.rule.EmbeddedDatabaseRule;
 
 import static java.util.stream.Collectors.toList;
-import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
-import static org.neo4j.helpers.collection.Iterators.asSet;
 import static org.neo4j.io.fs.FileUtils.deleteRecursively;
 
-/**
- * Tests functionality around missing or corrupted lucene label scan store index, and that
- * the database should repair (i.e. rebuild) that automatically and just work.
- */
-public class LuceneLabelScanStoreChaosIT
+public class LuceneLabelScanStoreChaosIT extends LabelScanStoreChaosIT
 {
-    @Rule
-    public final DatabaseRule dbRule = new EmbeddedDatabaseRule( getClass() );
-    private final Random random = new Random();
-
-    @Test
-    public void shouldRebuildDeletedLabelScanStoreOnStartup() throws Exception
-    {
-        // GIVEN
-        Node node1 = createLabeledNode( Labels.First );
-        Node node2 = createLabeledNode( Labels.First );
-        Node node3 = createLabeledNode( Labels.First );
-        deleteNode( node2 ); // just to create a hole in the store
-
-        // WHEN
-        dbRule.restartDatabase( deleteTheLabelScanStoreIndex() );
-
-        // THEN
-        assertEquals( asSet( node1, node3 ), getAllNodesWithLabel( Labels.First ) );
-    }
-
-    @Test
-    public void rebuildCorruptedLabelScanStoreToStartup() throws Exception
-    {
-        Node node = createLabeledNode( Labels.First );
-
-        dbRule.restartDatabase( corruptTheLabelScanStoreIndex() );
-
-        assertEquals( asSet( node ), getAllNodesWithLabel( Labels.First ) );
-    }
-
-    private DatabaseRule.RestartAction corruptTheLabelScanStoreIndex()
+    @Override
+    protected DatabaseRule.RestartAction corruptTheLabelScanStoreIndex()
     {
         return ( fs, storeDirectory ) -> {
             try
@@ -103,7 +62,8 @@ private DatabaseRule.RestartAction corruptTheLabelScanStoreIndex()
         };
     }
 
-    private DatabaseRule.RestartAction deleteTheLabelScanStoreIndex()
+    @Override
+    protected DatabaseRule.RestartAction deleteTheLabelScanStoreIndex()
     {
         return ( fs, storeDirectory ) -> {
             try
@@ -132,33 +92,6 @@ private List<File> labelScanStoreIndexDirectories( File storeDirectory )
         return (partitionDirs == null) ? Collections.emptyList() : Stream.of( partitionDirs ).collect( toList() );
     }
 
-    private Node createLabeledNode( Label... labels )
-    {
-        try ( Transaction tx = dbRule.getGraphDatabaseAPI().beginTx() )
-        {
-            Node node = dbRule.getGraphDatabaseAPI().createNode( labels );
-            tx.success();
-            return node;
-        }
-    }
-
-    private Set<Node> getAllNodesWithLabel( Label label )
-    {
-        try ( Transaction tx = dbRule.getGraphDatabaseAPI().beginTx() )
-        {
-            return asSet( dbRule.getGraphDatabaseAPI().findNodes( label ) );
-        }
-    }
-
-    private void deleteNode( Node node )
-    {
-        try ( Transaction tx = dbRule.getGraphDatabaseAPI().beginTx() )
-        {
-            node.delete();
-            tx.success();
-        }
-    }
-
     private void scrambleFile( File file ) throws IOException
     {
         try ( RandomAccessFile fileAccess = new RandomAccessFile( file, "rw" );
@@ -177,12 +110,7 @@ private void putRandomBytes( byte[] bytes )
     {
         for ( int i = 0; i < bytes.length; i++ )
         {
-            bytes[i] = (byte) random.nextInt();
+            bytes[i] = (byte) randomRule.nextInt();
         }
     }
-
-    private enum Labels implements Label
-    {
-        First, Second, Third
-    }
 }