Fixes from code review

Fixed - toString-implementations of Node and Edge value implementations - fixed argument name to `labels` method
neo4j · Jun 19, 2017 · 48f69b6 · 48f69b6
1 parent 8a0ea98
commit 48f69b6
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/community/values/src/main/java/org/neo4j/values/virtual/EdgeReference.java b/community/values/src/main/java/org/neo4j/values/virtual/EdgeReference.java
@@ -41,7 +41,7 @@ public <E extends Exception> void writeTo( AnyValueWriter<E> writer ) throws E
     @Override
     public String toString()
     {
-        return format( "-[%s]-", id );
+        return format( "-[%d]-", id );
     }
 
     @Override

diff --git a/community/values/src/main/java/org/neo4j/values/virtual/EdgeValue.java b/community/values/src/main/java/org/neo4j/values/virtual/EdgeValue.java
@@ -52,7 +52,7 @@ public <E extends Exception> void writeTo( AnyValueWriter<E> writer ) throws E
     @Override
     public String toString()
     {
-        return format( "-[%s]-", id );
+        return format( "-[%d]-", id );
     }
 
     @Override

diff --git a/community/values/src/main/java/org/neo4j/values/virtual/NodeReference.java b/community/values/src/main/java/org/neo4j/values/virtual/NodeReference.java
@@ -41,7 +41,7 @@ public <E extends Exception> void writeTo( AnyValueWriter<E> writer ) throws E
     @Override
     public String toString()
     {
-        return format( "(%s)", id );
+        return format( "(%d)", id );
     }
 
     @Override

diff --git a/community/values/src/main/java/org/neo4j/values/virtual/NodeValue.java b/community/values/src/main/java/org/neo4j/values/virtual/NodeValue.java
@@ -54,7 +54,7 @@ long id()
     @Override
     public String toString()
     {
-        return format( "(%s)", id );
+        return format( "(%d)", id );
     }
 
 }
diff --git a/community/values/src/main/java/org/neo4j/values/virtual/VirtualValues.java b/community/values/src/main/java/org/neo4j/values/virtual/VirtualValues.java
@@ -68,9 +68,9 @@ public static LabelValue label( int id, TextValue value )
         return new LabelValue( id, value );
     }
 
-    public static LabelSet labels( LabelValue... labelIds )
+    public static LabelSet labels( LabelValue... labels )
     {
-        return new LabelSet.ArrayBasedLabelSet( labelIds );
+        return new LabelSet.ArrayBasedLabelSet( labels );
     }
 
     public static NodeReference node( long id )