GenericKeyStateTest only use 16 bit code point string

Because comparison of strings with code points higher than 16 bits (supplementary code points) does not work, as shown by test in UTF8StringValueRandomTest. Also, don't share PageCursor between tests.
neo4j · Aug 30, 2018 · 49f546f · 49f546f
1 parent 0a75af9
commit 49f546f
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/community/kernel/src/test/java/org/neo4j/kernel/impl/index/schema/GenericKeyStateTest.java b/community/kernel/src/test/java/org/neo4j/kernel/impl/index/schema/GenericKeyStateTest.java
@@ -82,8 +82,6 @@ class GenericKeyStateTest
     @Inject
     private static RandomRule random;
 
-    private static final PageCursor cursor = ByteArrayPageCursor.wrap( PageCache.PAGE_SIZE );
-
     @BeforeEach
     public void setupRandomConfig()
     {
@@ -112,6 +110,12 @@ public int arrayMaxLength()
             {
                 return 10;
             }
+
+            @Override
+            public int maxCodePoint()
+            {
+                return RandomValues.MAX_16_BIT_CODE_POINT;
+            }
         } );
         random.reset();
     }
@@ -121,6 +125,7 @@ public int arrayMaxLength()
     void readWhatIsWritten( ValueGenerator valueGenerator )
     {
         // Given
+        PageCursor cursor = newPageCursor();
         GenericKeyState writeState = new GenericKeyState();
         Value value = valueGenerator.next();
         int offset = cursor.getOffset();
@@ -259,6 +264,7 @@ void mustProduceValidMinimalSplitters( ValueGenerator valueGenerator )
     void mustReportCorrectSize( ValueGenerator valueGenerator )
     {
         // Given
+        PageCursor cursor = newPageCursor();
         Value value = valueGenerator.next();
         GenericKeyState state = new GenericKeyState();
         state.writeValue( value, NEUTRAL );
@@ -533,6 +539,11 @@ private GenericKeyState genericKeyStateWithSomePreviousState( ValueGenerator val
         return to;
     }
 
+    private PageCursor newPageCursor()
+    {
+        return ByteArrayPageCursor.wrap( PageCache.PAGE_SIZE );
+    }
+
     @FunctionalInterface
     private interface ValueGenerator
     {